Skip to content

Conversation

@Damego
Copy link
Member

@Damego Damego commented Feb 20, 2023

About

This pull request:

  1. Allows commands to take the coroutine's name instead of requiring kwargs usage of the decorator.
  2. Adds user_context_menu and message_context_menu decorators.

Why this pr is breaking?
I marked all (except name) parameters for the context_menu decorator as keyword arguments because name is not requires anymore but context_type is. If you don't like it just say another way how to solve it.

Checklist

  • The pre-commit code linter has been run over all edited files to ensure the code is linted.
  • I've ensured the change(s) work on 3.8.6 and higher.
  • I have added the versionadded, versionchanged and deprecated to any new or changed user-facing function I committed.

Pull-Request specification

I've made this pull request: (check all that apply)

  • For the documentation
  • To add a new feature
  • As a general enhancement
  • As a refactor of the library/the library's code
  • To fix an existing bug
  • To resolve #ISSUENUMBER

This is:

  • A breaking change

@Damego Damego added the enhancement New feature or request label Feb 20, 2023
@LordOfPolls LordOfPolls merged commit ac5c055 into interactions-py:5.x Feb 21, 2023
@Damego Damego deleted the enhance-commands branch February 21, 2023 17:51
LordOfPolls pushed a commit that referenced this pull request Mar 13, 2023
* feat!: Add command's enhancements

* fix: incorrect type

* chore: bruh

* ci: correct from checks.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants